aboutsummaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorVladimir Serbinenko <phcoder@gmail.com>2014-11-22 21:12:14 +0100
committerVladimir Serbinenko <phcoder@gmail.com>2015-05-16 22:35:12 +0200
commit99bc2ec581a2c024e0455fb167b5c0f93716a954 (patch)
tree9be7a2db07e6a4ec2c7e31a97d9704463815b16c /src
parent3026e473dafa1d06f69f44fda19aab75fb15ed8a (diff)
downloadcoreboot-99bc2ec581a2c024e0455fb167b5c0f93716a954.tar.gz
coreboot-99bc2ec581a2c024e0455fb167b5c0f93716a954.tar.xz
coreboot-99bc2ec581a2c024e0455fb167b5c0f93716a954.zip
i945: Disable check for 2-dimm support.
The check is wrong. On Acer Aspire One it returns 0 despite 2 DIMMs working fine on the same channel if this check is disabled (tested by memtest). On boards that have only 1 DIMM per channel, the code will simply find no SPD and skip empty slot. Change-Id: I5f2fdcd1d948ebf3eabebaea4441af4c19e47f8f Signed-off-by: Vladimir Serbinenko <phcoder@gmail.com> Reviewed-on: http://review.coreboot.org/7568 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Reviewed-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Diffstat (limited to 'src')
-rw-r--r--src/northbridge/intel/i945/raminit.c14
1 files changed, 0 insertions, 14 deletions
diff --git a/src/northbridge/intel/i945/raminit.c b/src/northbridge/intel/i945/raminit.c
index c3f9bae06..401128715 100644
--- a/src/northbridge/intel/i945/raminit.c
+++ b/src/northbridge/intel/i945/raminit.c
@@ -211,16 +211,6 @@ static int sdram_capabilities_enhanced_addressing_xor(void)
return (!reg8);
}
-static int sdram_capabilities_two_dimms_per_channel(void)
-{
- u8 reg8;
-
- reg8 = pci_read_config8(PCI_DEV(0, 0x00, 0), 0xe8); /* CAPID0 + 8 */
- reg8 &= (1 << 0);
-
- return (reg8 != 0);
-}
-
// TODO check if we ever need this function
#if 0
static int sdram_capabilities_MEM4G_disable(void)
@@ -383,10 +373,6 @@ static void sdram_get_dram_configuration(struct sys_info *sysinfo)
if (!sdram_capabilities_dual_channel() && (i >> 1))
continue;
- /* Two DIMMs per channel not supported, but odd DIMM number? */
- if (!sdram_capabilities_two_dimms_per_channel() && (i& 1))
- continue;
-
printk(BIOS_DEBUG, "DDR II Channel %d Socket %d: ", (i >> 1), (i & 1));
if (spd_read_byte(device, SPD_MEMORY_TYPE) != SPD_MEMORY_TYPE_SDRAM_DDR2) {