aboutsummaryrefslogtreecommitdiffstats
path: root/src/mainboard/kontron/986lcd-m/mainboard.c
diff options
context:
space:
mode:
authorVarad Gautam <varadgautam@gmail.com>2015-03-11 09:54:41 +0530
committerMarc Jones <marc.jones@se-eng.com>2015-04-06 19:40:00 +0200
commit06ef04604570d402687245521731053c66888b15 (patch)
treece0fd5b994094f7228d7c18245f8758fd48676ee /src/mainboard/kontron/986lcd-m/mainboard.c
parent015f0aea5dc0cd391ddc34c1db6591d93d08e8a9 (diff)
downloadcoreboot-06ef04604570d402687245521731053c66888b15.tar.gz
coreboot-06ef04604570d402687245521731053c66888b15.tar.xz
coreboot-06ef04604570d402687245521731053c66888b15.zip
global: Refactor get_option usage
Restructure get_option() calls to avoid unnecessary return value checks by pre-assigning defaults to the options being retrieved. Change-Id: I9159afe149a8eeed0785d1efd6eee8420b88b8f4 Signed-off-by: Varad Gautam <varadgautam@gmail.com> Reviewed-on: http://review.coreboot.org/8631 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <pgeorgi@google.com> Reviewed-by: Marc Jones <marc.jones@se-eng.com>
Diffstat (limited to 'src/mainboard/kontron/986lcd-m/mainboard.c')
-rw-r--r--src/mainboard/kontron/986lcd-m/mainboard.c26
1 files changed, 13 insertions, 13 deletions
diff --git a/src/mainboard/kontron/986lcd-m/mainboard.c b/src/mainboard/kontron/986lcd-m/mainboard.c
index afca79600..d943127e3 100644
--- a/src/mainboard/kontron/986lcd-m/mainboard.c
+++ b/src/mainboard/kontron/986lcd-m/mainboard.c
@@ -79,19 +79,19 @@ static void hwm_setup(void)
int cpufan_speed = 0, sysfan_speed = 0;
int cpufan_temperature = 0, sysfan_temperature = 0;
- if (get_option(&cpufan_control, "cpufan_cruise_control") != CB_SUCCESS)
- cpufan_control = FAN_CRUISE_CONTROL_DISABLED;
- if (get_option(&cpufan_speed, "cpufan_speed") != CB_SUCCESS)
- cpufan_speed = FAN_SPEED_5625;
- //if (get_option(&cpufan_temperature, "cpufan_temperature") != CB_SUCCESS)
- // cpufan_temperature = FAN_TEMPERATURE_30DEGC;
-
- if (get_option(&sysfan_control, "sysfan_cruise_control") != CB_SUCCESS)
- sysfan_control = FAN_CRUISE_CONTROL_DISABLED;
- if (get_option(&sysfan_speed, "sysfan_speed") != CB_SUCCESS)
- sysfan_speed = FAN_SPEED_5625;
- //if (get_option(&sysfan_temperature, "sysfan_temperature") != CB_SUCCESS)
- // sysfan_temperature = FAN_TEMPERATURE_30DEGC;
+ cpufan_control = FAN_CRUISE_CONTROL_DISABLED;
+ get_option(&cpufan_control, "cpufan_cruise_control");
+ cpufan_speed = FAN_SPEED_5625;
+ get_option(&cpufan_speed, "cpufan_speed");
+ //cpufan_temperature = FAN_TEMPERATURE_30DEGC;
+ //get_option(&cpufan_temperature, "cpufan_temperature");
+
+ sysfan_control = FAN_CRUISE_CONTROL_DISABLED;
+ get_option(&sysfan_control, "sysfan_cruise_control");
+ sysfan_speed = FAN_SPEED_5625;
+ get_option(&sysfan_speed, "sysfan_speed");
+ //sysfan_temperature = FAN_TEMPERATURE_30DEGC;
+ //get_option(&sysfan_temperature, "sysfan_temperature");
// hwm_write(0x31, 0x20); // AVCC high limit
// hwm_write(0x34, 0x06); // VIN2 low limit