aboutsummaryrefslogtreecommitdiffstats
path: root/src/console
diff options
context:
space:
mode:
authorStefan Reinauer <reinauer@chromium.org>2015-01-05 13:12:38 -0800
committerKyösti Mälkki <kyosti.malkki@gmail.com>2015-01-09 06:12:22 +0100
commitd6865222c84c9da02cb515329af6a5384638d521 (patch)
tree813e9b2d76cb4d17d68acb505abac4279efbc3ad /src/console
parentc62ee70b6ef651288c4c4710319ee313b28fd520 (diff)
downloadcoreboot-d6865222c84c9da02cb515329af6a5384638d521.tar.gz
coreboot-d6865222c84c9da02cb515329af6a5384638d521.tar.xz
coreboot-d6865222c84c9da02cb515329af6a5384638d521.zip
misc: Drop print_ implementation from non-romcc boards
Because we had no stack on romcc boards, we had a separate, not as powerful clone of printk: print_*. Back in the day, like more than half a decade ago, we migrated a lot of boards to printk, but we never cleaned up the existing code to be consistent. Instead, we worked around the problem with a very messy console.h (nowadays the mess is hidden in romstage_console.c and early_print.h) This patch cleans up the generic code pieces to use printk() on all non-ROMCC boards. Our two remaining ROMCC boards are fixed up in this commit: bifferos/bifferboard and dmp/vortex86ex. Change-Id: I16676eeabe5c892c8e3c9f3c0cd3bae2e8fd74b6 Signed-off-by: Stefan Reinauer <stefan.reinauer@coreboot.org> Reviewed-on: http://review.coreboot.org/8115 Tested-by: build bot (Jenkins) Reviewed-by: Edward O'Callaghan <eocallaghan@alterapraxis.com> Reviewed-by: Andrew Wu <arw@dmp.com.tw> Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Diffstat (limited to 'src/console')
-rw-r--r--src/console/die.c6
-rw-r--r--src/console/post.c4
2 files changed, 3 insertions, 7 deletions
diff --git a/src/console/die.c b/src/console/die.c
index e6e968a5b..b0e04a490 100644
--- a/src/console/die.c
+++ b/src/console/die.c
@@ -25,13 +25,11 @@
#ifndef __ROMCC__
#define NORETURN __attribute__((noreturn))
-#else
-#define NORETURN
-#endif
/* Report a fatal error */
void NORETURN die(const char *msg)
{
- print_emerg(msg);
+ printk(BIOS_EMERG, "%s", msg);
halt();
}
+#endif
diff --git a/src/console/post.c b/src/console/post.c
index 4f2a87c93..df71a62d9 100644
--- a/src/console/post.c
+++ b/src/console/post.c
@@ -150,9 +150,7 @@ void post_code(uint8_t value)
{
#if !CONFIG_NO_POST
#if CONFIG_CONSOLE_POST
- print_emerg("POST: 0x");
- print_emerg_hex8(value);
- print_emerg("\n");
+ printk(BIOS_EMERG, "POST: 0x%02x\n", value);
#endif
#if CONFIG_CMOS_POST
cmos_post_code(value);