path: root/src/console
diff options
authorGabe Black <gabeblack@google.com>2014-04-02 17:57:05 -0700
committerMike Loptien <mike.loptien@se-eng.com>2014-10-07 23:41:28 +0200
commit35382a6eeb6634c291ffb67a3c4fa7a4601a7328 (patch)
tree12552f6b75fbb014b68b0075486d0e7e53fb875c /src/console
parent34c5933a66caf839ac82c2bdf3e50bcce816b36d (diff)
cbmem console: Locate the preram console with a symbol instead of a section.
On non-x86 systems, the location of the preram CBMEM console may not be in a predictable place relative to other things in the linker script. That makes it difficult to work with as its own section because the linker will complain if you try to move backwards as it lays out memory. If the console header is treated as an actual blob of memory which has to be put in the image, we'd have to predict where to put it so that it isn't before something with a lower address or after something with a higher address. Symbols, on the other hand, can be defined arbitrarily. Change-Id: I3257b981eee0c15bb997a9f2c55a03494c6ec6f0 Signed-off-by: Gabe Black <gabeblack@google.com> Reviewed-on: https://chromium-review.googlesource.com/193164 Reviewed-by: Tom Warren <twarren@nvidia.com> Reviewed-by: Aaron Durbin <adurbin@chromium.org> Commit-Queue: Gabe Black <gabeblack@chromium.org> Tested-by: Gabe Black <gabeblack@chromium.org> (cherry picked from commit a492761c27076bcac080013d509ae4aafd6dc3e3) Signed-off-by: Isaac Christensen <isaac.christensen@se-eng.com> Reviewed-on: http://review.coreboot.org/7013 Tested-by: build bot (Jenkins) Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
Diffstat (limited to 'src/console')
1 files changed, 5 insertions, 5 deletions
diff --git a/src/console/Kconfig b/src/console/Kconfig
index 472ac5c8d..619af56ba 100644
--- a/src/console/Kconfig
+++ b/src/console/Kconfig
@@ -184,15 +184,15 @@ config CONSOLE_CBMEM_BUFFER_SIZE
value (128K or 0x20000 bytes) is large enough to accommodate
even the BIOS_SPEW level.
depends on CONSOLE_CBMEM
- hex "Room allocated for console output in Cache as RAM"
+ hex "Room allocated for console output before RAM is initialized"
default 0xc00
Console is used before RAM is initialized. This is the room reserved
- in the DCACHE based RAM to keep console output before it can be
- saved in a CBMEM buffer. 3K bytes should be enough even for the
- BIOS_SPEW level.
+ in the DCACHE based RAM, SRAM, etc. to keep console output before it
+ can be saved in a CBMEM buffer. 3K bytes should be enough even for
+ the BIOS_SPEW level.
bool "QEMU debug console output"