aboutsummaryrefslogtreecommitdiffstats
path: root/src/arch/x86/init
diff options
context:
space:
mode:
authorKyösti Mälkki <kyosti.malkki@gmail.com>2014-10-16 12:47:25 +0300
committerKyösti Mälkki <kyosti.malkki@gmail.com>2014-10-19 06:14:05 +0200
commit1729cd85744129104e3e41aac1f18e43b62f79ff (patch)
tree37a9e44516fc1d1da23e75266aa672099a2872f2 /src/arch/x86/init
parentd05d0db0d0cb76776addbd75d264e713dda47880 (diff)
downloadcoreboot-1729cd85744129104e3e41aac1f18e43b62f79ff.tar.gz
coreboot-1729cd85744129104e3e41aac1f18e43b62f79ff.tar.xz
coreboot-1729cd85744129104e3e41aac1f18e43b62f79ff.zip
x86 romstage: Move stack just below RAMTOP
Placement of romstage stack in RAM was vulnerable for getting corrupted by decompressed ramstage. Change-Id: Ic032bd3e69f4ab8dab8e5932df39fab70aa3e769 Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: http://review.coreboot.org/7096 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin <adurbin@google.com>
Diffstat (limited to 'src/arch/x86/init')
-rw-r--r--src/arch/x86/init/crt0_romcc_epilogue.inc2
-rw-r--r--src/arch/x86/init/prologue.inc1
2 files changed, 1 insertions, 2 deletions
diff --git a/src/arch/x86/init/crt0_romcc_epilogue.inc b/src/arch/x86/init/crt0_romcc_epilogue.inc
index 419418d64..791ab8e36 100644
--- a/src/arch/x86/init/crt0_romcc_epilogue.inc
+++ b/src/arch/x86/init/crt0_romcc_epilogue.inc
@@ -11,7 +11,7 @@ __main:
post_code(POST_PREPARE_RAMSTAGE)
cld /* clear direction flag */
- movl $ROMSTAGE_STACK, %esp
+ movl $CONFIG_RAMTOP, %esp
movl %esp, %ebp
call copy_and_run
diff --git a/src/arch/x86/init/prologue.inc b/src/arch/x86/init/prologue.inc
index 84e465c18..bef42a382 100644
--- a/src/arch/x86/init/prologue.inc
+++ b/src/arch/x86/init/prologue.inc
@@ -18,7 +18,6 @@
*/
#include <cpu/x86/post_code.h>
-#include <cpu/x86/stack.h>
.section ".rom.data", "a", @progbits
.section ".rom.text", "ax", @progbits