path: root/src/arch/arm/include
diff options
authorJulius Werner <jwerner@chromium.org>2014-01-24 16:23:08 -0800
committerMarc Jones <marc.jones@se-eng.com>2014-11-13 06:49:41 +0100
commit7c6e489b23476ad6149c173b6971327aa2eb7726 (patch)
tree07cf2798f857b5455ac83989c774984c010a8470 /src/arch/arm/include
parent168b0f9e380ababdc1189bac6cd8b121d1adf3b7 (diff)
arm: Put assembly functions into separate sections
This patch changes the ENTRY() macro in asm.h to create a new section for every assembler function, thus providing dcache_clean/invalidate_all and friends with the same --gc-sections goodness that our C functions have. This requires a few minor changes of moving around data (to make sure it ends up in the right section) and changing some libgcc functions (which apparently need to have two names?), but nothing serious. (You may note that some of our assembly functions have data, sometimes even writable, within the same .text section. This has been this way before and I'm not looking to change it for now, although it's not totally clean. Since we don't enforce read-only sections through paging, it doesn't really hurt.) BUG=None TEST=Nyan and Snow still boot. Confirm dcache_invalidate_all is not output into any binary anymore since no one actually uses it. Original-Change-Id: I247b29d6173ba516c8dff59126c93b66f7dc4b8d Original-Signed-off-by: Julius Werner <jwerner@chromium.org> Original-Reviewed-on: https://chromium-review.googlesource.com/183891 (cherry picked from commit 4a3f2e45e06cc8592d56c3577f41ff879f10e9cc) Signed-off-by: Marc Jones <marc.jones@se-eng.com> Change-Id: Ieaa4f2ea9d81c5b9e2b36a772ff9610bdf6446f9 Reviewed-on: http://review.coreboot.org/7451 Tested-by: build bot (Jenkins) Reviewed-by: David Hendricks <dhendrix@chromium.org>
Diffstat (limited to 'src/arch/arm/include')
1 files changed, 2 insertions, 4 deletions
diff --git a/src/arch/arm/include/arch/asm.h b/src/arch/arm/include/arch/asm.h
index a57ce4daf..420fa602a 100644
--- a/src/arch/arm/include/arch/asm.h
+++ b/src/arch/arm/include/arch/asm.h
@@ -43,16 +43,14 @@
#define ENTRY(name) \
- .globl name; \
+ .section .text.name, "ax", %progbits; \
+ .global name; \
#define END(name) \
.size name, .-name
-/* Everything should go into the text section by default. */
- .text
/* Thumb code uses the (new) unified assembly syntax. */
THUMB( .syntax unified )