aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEdward O'Callaghan <eocallaghan@alterapraxis.com>2014-05-24 04:01:38 +1000
committerIdwer Vollering <vidwer@gmail.com>2014-05-24 21:02:14 +0200
commit8f9132fab10603abf75b8862418000669dfe9a27 (patch)
tree42b11303feb0676dcfc8b8a15a39321b3d8b3bda
parent6cec824a28b7325337d251d87a5e47c92943cbed (diff)
downloadcoreboot-8f9132fab10603abf75b8862418000669dfe9a27.tar.gz
coreboot-8f9132fab10603abf75b8862418000669dfe9a27.tar.xz
coreboot-8f9132fab10603abf75b8862418000669dfe9a27.zip
mainboard/amd: Incorrect usage of logical vs. bitwise and
Spotted by Clang Change-Id: I26201c7f5e421c38d3965d8e7e62c4a8e670e449 Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com> Reviewed-on: http://review.coreboot.org/5833 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth <martin.roth@se-eng.com>
-rw-r--r--src/mainboard/amd/dinar/gpio.c2
-rw-r--r--src/mainboard/amd/torpedo/gpio.c2
2 files changed, 2 insertions, 2 deletions
diff --git a/src/mainboard/amd/dinar/gpio.c b/src/mainboard/amd/dinar/gpio.c
index 4e60f18fa..0b3a89b88 100644
--- a/src/mainboard/amd/dinar/gpio.c
+++ b/src/mainboard/amd/dinar/gpio.c
@@ -256,7 +256,7 @@ gpioEarlyInit(
// WAIT POWER READY: GPIO28 (MXM_PWRGD)
//while (!(Mmio8 (GpioMmioAddr, SB_GPIO_REG28) && BIT7)){}
ReadMEM (GpioMmioAddr + SB_GPIO_REG28, AccWidthUint8, &Data8);
- while (!(Data8 && BIT7))
+ while (!(Data8 & BIT7))
{
ReadMEM (GpioMmioAddr + SB_GPIO_REG28, AccWidthUint8, &Data8);
}
diff --git a/src/mainboard/amd/torpedo/gpio.c b/src/mainboard/amd/torpedo/gpio.c
index d2d2bea50..a8aba5e13 100644
--- a/src/mainboard/amd/torpedo/gpio.c
+++ b/src/mainboard/amd/torpedo/gpio.c
@@ -255,7 +255,7 @@ gpioEarlyInit(
// WAIT POWER READY: GPIO28 (MXM_PWRGD)
//while (!(Mmio8 (GpioMmioAddr, SB_GPIO_REG28) && BIT7)){}
ReadMEM (GpioMmioAddr + SB_GPIO_REG28, AccWidthUint8, &Data8);
- while (!(Data8 && BIT7))
+ while (!(Data8 & BIT7))
{
ReadMEM (GpioMmioAddr + SB_GPIO_REG28, AccWidthUint8, &Data8);
}