aboutsummaryrefslogtreecommitdiffstats
path: root/.gitreview
diff options
context:
space:
mode:
authorPatrick Georgi <patrick@georgi-clan.de>2014-09-05 23:54:04 +0200
committerPatrick Georgi <patrick@georgi-clan.de>2014-09-06 09:21:07 +0200
commit34e76152351a9c846d850064990a37e3d453d97f (patch)
treef4a6171bb92c8a08cfc196d7abf5437f70a4fccd /.gitreview
parent2d7bd8a6ebf6844b0cdef80eaaef69f39d08f076 (diff)
downloadcoreboot-34e76152351a9c846d850064990a37e3d453d97f.tar.gz
coreboot-34e76152351a9c846d850064990a37e3d453d97f.tar.xz
coreboot-34e76152351a9c846d850064990a37e3d453d97f.zip
romcc: avoid use-after-free
Windows bugchecks on this for a while, so we ifndef'd the free() call out. Now some Linuxes (depending on their glibc) also fail on it, so just remove the call altogether at the cost of some leaked memory (couple hundred kilobytes) because tracking down the precise fix is too hard. In case someone wants to fix it, valgrind sees the issues, so revert this change and work on romcc's memory management until valgrind is happy. To get a fix in, provide a good explanation why your change is actually the right way to fix it - for silencing valgrind, this change will do. Change-Id: Iae3f847e09a0d7bcb8bb4f50983a1b0727570b23 Signed-off-by: Patrick Georgi <patrick@georgi-clan.de> Reviewed-on: http://review.coreboot.org/6846 Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org> Tested-by: build bot (Jenkins)
Diffstat (limited to '.gitreview')
0 files changed, 0 insertions, 0 deletions