aboutsummaryrefslogtreecommitdiffstats
path: root/qgroup-verify.c
diff options
context:
space:
mode:
authorQu Wenruo <quwenruo@cn.fujitsu.com>2016-06-16 09:15:51 +0800
committerDavid Sterba <dsterba@suse.com>2016-06-17 17:05:22 +0200
commitdf05c7ed455f519e6e15e46196392e4757257305 (patch)
treebf1f4b95419f91fa8be780d79851c473a94aceb1 /qgroup-verify.c
parentb8288277fbb0a46fbc607fd3c5090c03e9e22966 (diff)
downloadbtrfs-progs-df05c7ed455f519e6e15e46196392e4757257305.tar.gz
btrfs-progs-df05c7ed455f519e6e15e46196392e4757257305.tar.xz
btrfs-progs-df05c7ed455f519e6e15e46196392e4757257305.zip
btrfs-progs: qgroup: Fix a bug that fails to skip rescan running case
Commit 6bdf962fe35a8648d(btrfs-progs: Read qgroup status for qgroup verify) will read qgroup status, and then use it to skip qgroup reporting. However since the rescan_running/inconsistent flags are only 1 bit long, while qgroup flags & BTRFS_QGROUP_FLAGS returns value longer than 1bit, it doesn't work. Fix it by doing double negation on (flags & BTRFS_QGROUP_FLAGS) to convert it to either 1 or 0. Signed-off-by: Qu Wenruo <quwenruo@cn.fujitsu.com> Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'qgroup-verify.c')
-rw-r--r--qgroup-verify.c9
1 files changed, 7 insertions, 2 deletions
diff --git a/qgroup-verify.c b/qgroup-verify.c
index 1a0d38c..86dcd6d 100644
--- a/qgroup-verify.c
+++ b/qgroup-verify.c
@@ -711,8 +711,13 @@ static void read_qgroup_status(struct btrfs_path *path,
status_item = btrfs_item_ptr(path->nodes[0], path->slots[0],
struct btrfs_qgroup_status_item);
flags = btrfs_qgroup_status_flags(path->nodes[0], status_item);
- counts->qgroup_inconsist = flags & BTRFS_QGROUP_STATUS_FLAG_INCONSISTENT;
- counts->rescan_running = flags & BTRFS_QGROUP_STATUS_FLAG_RESCAN;
+ /*
+ * Since qgroup_inconsist/rescan_running is just one bit,
+ * assign value directly won't work.
+ */
+ counts->qgroup_inconsist = !!(flags &
+ BTRFS_QGROUP_STATUS_FLAG_INCONSISTENT);
+ counts->rescan_running = !!(flags & BTRFS_QGROUP_STATUS_FLAG_RESCAN);
}
static int load_quota_info(struct btrfs_fs_info *info)