path: root/string
diff options
authorCarlos O'Donell <carlos@redhat.com>2018-06-22 09:28:47 -0400
committerCarlos O'Donell <carlos@redhat.com>2018-06-29 22:39:06 -0400
commit2827ab990aefbb0e53374199b875d98f116d6390 (patch)
tree0063b4c07be87d887d4a4893b9681b9e61479e8b /string
parent37d3d244e1a0ca7e7ac89b8e768e665adbb2e2d8 (diff)
libc: Extend __libc_freeres framework (Bug 23329).
The __libc_freeres framework does not extend to non-libc.so objects. This causes problems in general for valgrind and mtrace detecting unfreed objects in both libdl.so and libpthread.so. This change is a pre-requisite to properly moving the malloc hooks out of malloc since such a move now requires precise accounting of all allocated data before destructors are run. This commit adds a proper hook in libc.so.6 for both libdl.so and for libpthread.so, this ensures that shm-directory.c which uses freeit () to free memory is called properly. We also remove the nptl_freeres hook and fall back to using weak-ref-and-check idiom for a loaded libpthread.so, thus making this process similar for all DSOs. Lastly we follow best practice and use explicit free calls for both libdl.so and libpthread.so instead of the generic hook process which has undefined order. Tested on x86_64 with no regressions. Signed-off-by: DJ Delorie <dj@redhat.com> Signed-off-by: Carlos O'Donell <carlos@redhat.com>
Diffstat (limited to 'string')
1 files changed, 1 insertions, 2 deletions
diff --git a/string/strerror_l.c b/string/strerror_l.c
index 2a9c3b5e0b2..2a62b1f12c3 100644
--- a/string/strerror_l.c
+++ b/string/strerror_l.c
@@ -21,7 +21,7 @@
#include <stdlib.h>
#include <string.h>
#include <sys/param.h>
+#include <libc-symbols.h>
static __thread char *last_value;
@@ -56,7 +56,6 @@ strerror_l (int errnum, locale_t loc)
return (char *) translate (_sys_errlist_internal[errnum], loc);
__strerror_thread_freeres (void)