aboutsummaryrefslogtreecommitdiffstats
path: root/ChangeLog
diff options
context:
space:
mode:
authorAdhemerval Zanella <adhemerval.zanella@linaro.org>2018-08-27 16:16:43 -0300
committerAdhemerval Zanella <adhemerval.zanella@linaro.org>2018-09-25 16:27:50 -0300
commitb5c45e83753b27dc538dff2d55d4410c385cf3a4 (patch)
tree7c88e09f3bcf2edbdf2a1196b50c54ab7459b0c5 /ChangeLog
parentd62f9ec0cce26a275ec68f4564814041a33395b1 (diff)
downloadtermbaud-b5c45e83753b27dc538dff2d55d4410c385cf3a4.tar.gz
termbaud-b5c45e83753b27dc538dff2d55d4410c385cf3a4.tar.xz
termbaud-b5c45e83753b27dc538dff2d55d4410c385cf3a4.zip
Fix ifunc support with DT_TEXTREL segments (BZ#20480)
Currently, DT_TEXTREL is incompatible with IFUNC. When DT_TEXTREL or DF_TEXTREL is seen, the dynamic linker calls __mprotect on the segments with PROT_READ|PROT_WRITE before applying dynamic relocations. It leads to segfault when performing IFUNC resolution (which requires PROT_EXEC as well for the IFUNC resolver). This patch makes it call __mprotect with extra PROT_WRITE bit, which will keep the PROT_EXEC bit if exists, and thus fixes the segfault. FreeBSD rtld libexec/rtld-elf/rtld.c (reloc_textrel_prot) does the same. Checked on x86_64-linux-gnu, i686-linux-gnu, aarch64-linux-gnu, sparc64-linux-gnu, sparcv9-linux-gnu, and armv8-linux-gnueabihf. Adam J. Richte <adam_richter2004@yahoo.com> Adhemerval Zanella <adhemerval.zanella@linaro.org> Fangrui Song <maskray@google.com> [BZ #20480] * config.h.in (CAN_TEXTREL_IFUNC): New define. * configure.ac: Add check if linker supports textrel relocation with ifunc. * elf/dl-reloc.c (_dl_relocate_object): Use all required flags on DT_TEXTREL segments, not only PROT_READ and PROT_WRITE. * elf/Makefile (ifunc-pie-tests): Add tst-ifunc-textrel. (CFLAGS-tst-ifunc-textrel.c): New rule. * elf/tst-ifunc-textrel.c: New file.
Diffstat (limited to 'ChangeLog')
-rw-r--r--ChangeLog15
1 files changed, 15 insertions, 0 deletions
diff --git a/ChangeLog b/ChangeLog
index bd08c4bf456..9afe9a75f04 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,18 @@
+2018-09-25 Adam J. Richte <adam_richter2004@yahoo.com>
+ Adhemerval Zanella <adhemerval.zanella@linaro.org>
+ Fangrui Song <maskray@google.com>
+
+ [BZ #20480]
+ * config.make.in (have-textrel_ifunc): New define.
+ * configure.ac: Add check if linker supports textrel relocation with
+ ifunc.
+ * elf/Makefile [have-textrel_ifunc == yes] (ifunc-pie-tests): Add
+ tst-ifunc-textrel.
+ (CFLAGS-tst-ifunc-textrel.c): New rule.
+ * elf/dl-reloc.c (_dl_relocate_object): Use all required flags on
+ DT_TEXTREL segments, not only PROT_READ and PROT_WRITE.
+ * elf/tst-ifunc-textrel.c: New file.
+
2018-09-25 Joseph Myers <joseph@codesourcery.com>
* sysdeps/unix/sysv/linux/sys/procfs.h: Include