|author||Joseph Myers <email@example.com>||2018-09-11 14:51:40 +0000|
|committer||Joseph Myers <firstname.lastname@example.org>||2018-09-11 14:51:40 +0000|
Remove x86_64 math_private.h asms.
The x86_64 math_private.h has asm versions of the macros to reinterpret between floating-point and integer types. This is the sort of thing we now strongly discourage; the expectation in such cases, where the generic C code gives the compiler all the information needed about the required semantics, is that you should get the compiler to do the right thing for the generic C code rather than writing an asm version. Trivial tests showed GCC generates the expected single instructions for reinterpretation from floating point to integer. In the other direction, it goes via memory when the asms don't; I asked about this in GCC bug 87236 and was advised this was deliberate for generic tuning because it was faster that way on some AMD processors (but -mtune=intel, and -Os with the latest GCC, avoid going via memory). The asms don't and can't know about those tuning details, so that's evidence that they are actually making the code worse. This patch removes the asms accordingly. Tested for x86_64. * sysdeps/x86_64/fpu/math_private.h (MOVD): Remove macro. (MOVQ): Likewise. (EXTRACT_WORDS64): Likewise. (INSERT_WORDS64): Likewise. (GET_FLOAT_WORD): Likewise. (SET_FLOAT_WORD): Likewise.
Diffstat (limited to 'ChangeLog')
1 files changed, 7 insertions, 0 deletions
diff --git a/ChangeLog b/ChangeLog
index 7ec115f5886..d1aff069dad 100644
@@ -1,5 +1,12 @@
2018-09-11 Joseph Myers <email@example.com>
+ * sysdeps/x86_64/fpu/math_private.h (MOVD): Remove macro.
+ (MOVQ): Likewise.
+ (EXTRACT_WORDS64): Likewise.
+ (INSERT_WORDS64): Likewise.
+ (GET_FLOAT_WORD): Likewise.
+ (SET_FLOAT_WORD): Likewise.
* scripts/build-many-glibcs.py (Context.__init__): Add full_gcc
(Config.build_gcc): Use --disable-libsanitizer for first GCC