aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* staging: rtl8193*: Remove double testJulia Lawall2010-08-312-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | The 1 element of the array is tested twice. Change the code so that the remaining 3 element of the array is tested instead of testing the 1 element a second time. The sematic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @expression@ expression E; @@ ( * E || ... || E | * E && ... && E ) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: solo6x10: fixed assignments in if conditions in solo6010-core.cPrashant P. Shah2010-08-311-14/+26
| | | | | | | | This is a patch to the solo6010-core.c file that fixes the assignments in if condition style issues found by the checkpatch.pl tool. Signed-off-by: Prashant P. Shah <pshah.mumbai@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: r8712u: Update copy-to list for patchesLarry Finger2010-08-311-1/+6
| | | | | Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: mrst-touchscreen: Fix wrong Makefile configAlek Du2010-08-312-2/+2
| | | | | | | | The config name is wrong in drivers/staging/Makefile... The object name is wrong in drivers/staging/mrst-touchscreen/Makefile... Signed-off-by: Alek Du <alek.du@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: mrst-touchscreen: fix channel allocation in the touch screen driverArjan van de Ven2010-08-311-17/+12
| | | | | | | | | | | | | | | | | | | | | | the touch screen driver tries to find a range of free channels (which are an array of bytes), by scanning for the "end of used channel" marker. however it tries to be WAAAAY too smart and does 32 bit logic on 8 bit quantities, and in the process completely gets it wrong (repeatedly read the same register instead of incrementing in the loop, assuming that if any of the 4 bytes in the 32 byte quantity is free, all four are free, returning the channel number divided by 4 rather than the actual first free channel number) On the setting side, the same mistakes are made by and large; changed this to just use the byte SCU write functions.... with these fixes we go from a completely non detected touchscreen to something that appears to completely get detected. (after also fixing the ordering issue that Jacobs patch should solve) Signed-off-by: Arjan van de Ven <arjan@linux.intel.com> Signed-off-by: Alan Cox <alan@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: ti-st: remove st_get_plat_devicePavan Savoy2010-08-314-10/+24
| | | | | | | | | | | | | | | | | In order to support multiple ST platform devices, a new symbol 'st_get_plat_device' earlier needed to be exported by the arch/XX/brd-XX.c file which intends to add the ST platform device. On removing this dependency, now inside ST driver maintain the array of ST platform devices that would be registered. As of now let id=0, as and when we end up having such platforms where mutliple ST devices can exist, id would come from protocol drivers (BT, FM and GPS) as to on which platform device they want to register to. Signed-off-by: Pavan Savoy <pavan_savoy@ti.com> Acked-by: Randy Dunlap <randy.dunlap@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: comedi: fix brace coding style issue in dt2817.cSunny Aujla2010-08-311-7/+7
| | | | | | | | This is a patch to the dt2817.c file that fixes up all coding style issues found by the checkpatch.pl tool Signed-off-by: Sunny Aujla <sunnyfedora99@googlemail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: RT2860: Fixed all warnings and errors in the iface directoryNeil Munro2010-08-313-78/+94
| | | | | | | | | | | I have cleaned both files inside the iface directory (fileo rtmp_pci.h and rtmp_usb.h). I am not sure about some of the changes I have made however my adjustments have solved all errors. There were also a few issues on my machine with ap.h on my machine, however I have since cleaned that too. Signed-off-by: Neil Munro <neilmunro@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: rtl81*: Fix spelling fuction -> function in commentsStefan Weil2010-08-313-4/+4
| | | | | | | | | | | Obviously the wrong spelling was copied a lot of times. A similar patch for the non-staging part of linux is committed by Jiri Kosina. Cc: devel@driverdev.osuosl.org Signed-off-by: Stefan Weil <weil@mail.berlios.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: rtl8192e: Cleanup style and whitespaceRamkumar Ramachandra2010-08-311-35/+36
| | | | | | | | Replace C99-style comments with C89-style comments, fix some typos, and fix whitespace to use only tabs. Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: Use available error codesJulia Lawall2010-08-313-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | An error code is stored in a variable, but 0 is returned instead. Use the variable instead of 0. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r@ local idexpression x; constant C; @@ if (...) { ... x = -C ... when != x ( return <+...x...+>; | return NULL; | return; | * return ...; ) } // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: cx25821: clenup warnings found by checkpatch.pl tool in ↵Gorskin Ilya2010-08-312-14/+17
| | | | | | | | | | cx25821-audio-upstream.c and cx25821-audio.h. This is a patch to the cx25821-audio-upstream.c and cx25821-audio.h that fixes up a warnings found by checkpatch.pl tool. Signed-off-by: Ilya Gorskin <Revent82@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: rtl8192e: Remove redundant brackets around return valuesMike McCormack2010-08-313-8/+8
| | | | | Signed-off-by: Mike McCormack <mikem@ring3k.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: rtl8192e: Remove pointless return statementsMike McCormack2010-08-314-19/+1
| | | | | Signed-off-by: Mike McCormack <mikem@ring3k.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: rtl8192e: Remove unnecessary externsMike McCormack2010-08-311-3/+3
| | | | | Signed-off-by: Mike McCormack <mikem@ring3k.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: rtl8192e: Remove unused functionMike McCormack2010-08-312-21/+0
| | | | | Signed-off-by: Mike McCormack <mikem@ring3k.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: rtl8192e: Don't compare bHwRadioOff with trueMike McCormack2010-08-313-24/+24
| | | | | Signed-off-by: Mike McCormack <mikem@ring3k.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: rtl8192e: Make functions staticMike McCormack2010-08-311-13/+11
| | | | | | | | Make functions static and move their declarations to the top of the file. Signed-off-by: Mike McCormack <mikem@ring3k.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: rtl8192e: Remove backslashes at end of linesMike McCormack2010-08-315-45/+45
| | | | | Signed-off-by: Mike McCormack <mikem@ring3k.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: rtl8192e: Simplify some return codesMike McCormack2010-08-311-20/+4
| | | | | Signed-off-by: Mike McCormack <mikem@ring3k.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: rtl8192e: Delete unused function dm_shadow_init()Mike McCormack2010-08-312-44/+0
| | | | | Signed-off-by: Mike McCormack <mikem@ring3k.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: xgifb: fix lots of sparse warningsRandy Dunlap2010-08-318-409/+462
| | | | | | | | | | | | | | Fix many sparse warnings about data or functions being static. Fix many sparse warnings about data or functions not being used (put them inside #if 0/#endif blocks). Fix sparse warnings about 0 being used for NULL. Fixed a small bit of source formatting when those lines were being modified anyway, but there is still lots of this yet to be done. Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> Cc: devel@driverdev.osuosl.org Cc: Arnaud Patard <apatard@mandriva.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: solo6x10: return -EFAULT on copy_to_user errorsDan Carpenter2010-08-311-1/+1
| | | | | | | | copy_to_user() returns the number of bytes remaining to be copied, but we want to return a negative error code here. Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: adis16255: fix sysfs leakKulikov Vasiliy2010-08-311-1/+3
| | | | | | | | Original code does not call sysfs_remove_group() on error. This can lead to NULL dereference. Signed-off-by: Kulikov Vasiliy <segooon@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: tm6000: fix memory leakKulikov Vasiliy2010-08-311-2/+5
| | | | | | | Original code doesn't call kfree(chip) on error. Signed-off-by: Kulikov Vasiliy <segooon@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: usbip: fix memory leakKulikov Vasiliy2010-08-311-1/+1
| | | | | | | | If stub_probe() failed then do not increase interf_count. In original code sdev was leaked as its interf_count never reaches 0. Signed-off-by: Kulikov Vasiliy <segooon@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: lirc: fix compiler warningJarod Wilson2010-08-311-2/+2
| | | | | | | | | | | | | | | | | | | | On Fri, Aug 13, 2010 at 03:38:40PM +0200, Dan Carpenter wrote: > Speak of left over stuff, it's weird that I didn't notice this before > but gcc complains about an unitialized variable in > imon_incoming_packet(). > > drivers/staging/lirc/lirc_imon.c: In function ‘imon_incoming_packet’: > drivers/staging/lirc/lirc_imon.c:661: warning: ‘chunk_num’ may be used > uninitialized in this function > > I don't know how to fix that, but it looks important. Ew. Yeah, that doesn't look so hot like it is right now. The old lirc_imon driver had chunk_num = buf[7], and made much more extensive use of chunk_num. Simply removing chunk_num and using buf[7] should be fine. Signed-off-by: Jarod Wilson <jarod@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: cx25821: call disable_pci_device() if pci_probe() failedKulikov Vasiliy2010-08-311-4/+9
| | | | | | | | | Driver should call disable_pci_device() if it returns from pci_probe() with error. Also it must not be called if pci_request_region() fails as it means that somebody uses device resources and rules the device. Signed-off-by: Kulikov Vasiliy <segooon@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: sm7xx: call disable_pci_device() if pci_probe() failedKulikov Vasiliy2010-08-311-5/+8
| | | | | | | | Driver should call disable_pci_device() if it returns from pci_probe() with error. Signed-off-by: Kulikov Vasiliy <segooon@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: rtl8187e: call disable_pci_device() if pci_probe() failedKulikov Vasiliy2010-08-311-3/+7
| | | | | | | | Driver should call disable_pci_device() if it returns from pci_probe() with error. Signed-off-by: Kulikov Vasiliy <segooon@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: quickstart: acpi_status is unsignedDan Carpenter2010-08-311-4/+3
| | | | | | | | | acpi_bus_register_driver() returns an int, not acpi_status. It returns zero on success and negative error codes on failure, but acpi_status is unsigned. We can just use "ret" here. Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: ti-st: writing past end of arrayDan Carpenter2010-08-311-3/+2
| | | | | | | | In the original source it would write past the end of the array before returning the error code. Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: rtl8192e: add curly braces to if statementDan Carpenter2010-08-311-8/+8
| | | | | | | | | | | | | | In the original code there was some extra semicolons after the if statement: if (!channel_map[ieee->current_network.channel]); ^^^ >From the indenting it looked like that should be curly braces instead. Also I made some white space changes to stop checkpatch.pl from complaining. Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: lirc: remove unneeded variableDan Carpenter2010-08-311-3/+0
| | | | | | | | We never use control_req so I removed it. Signed-off-by: Dan Carpenter <error27@gmail.com> Acked-by: Jarod Wilson <jarod@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: spectra: call disable_pci_device() if pci_probe() failedKulikov Vasiliy2010-08-311-2/+5
| | | | | | | | Driver should call disable_pci_device() if it returns from pci_probe() with error. Signed-off-by: Kulikov Vasiliy <segooon@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: rtl8187se: call disable_pci_device() if pci_probe() failedKulikov Vasiliy2010-08-311-3/+7
| | | | | | | | Driver should call disable_pci_device() if it returns from pci_probe() with error. Signed-off-by: Kulikov Vasiliy <segooon@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: crystalhd: call disable_pci_device() if pci_probe() failedKulikov Vasiliy2010-08-311-0/+1
| | | | | | | | | Driver should call disable_pci_device() if it returns from pci_probe() with error. Signed-off-by: Kulikov Vasiliy <segooon@gmail.com> Acked-by: Jarod Wilson <jarod@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: xgifb: use DEFINE_PCI_DEVICE_TABLE() macroJavier Martinez Canillas2010-08-311-2/+1
| | | | | | | Use DEFINE_PCI_DEVICE_TABLE() to make xgifb_pci_table const and marked as __devinitconst Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: comedi (cb_pcidas): use PCI_DEVICE() macroJavier Martinez Canillas2010-08-311-10/+9
| | | | | | | This is the first of a patch series that uses PCI_DEVICE() macro for pci table entries on comedi drivers and thus improving readability. Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: comedi (cb_pcidda): use PCI_DEVICE() macroJavier Martinez Canillas2010-08-311-8/+7
| | | | | | | Use PCI_DEVICE() macro for pci table entries on comedi driver and thus improves readability. Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: comedi (cb_pcidio): user PCI_DEVICE() macroJavier Martinez Canillas2010-08-311-5/+4
| | | | | | | Use PCI_DEVICE() macro for pci table entries on comedi driver and thus improves readability. Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: comedi (rtd520): use PCI_DEVICE() macroJavier Martinez Canillas2010-08-311-4/+3
| | | | | | | Use PCI_DEVICE() macro for pci table entries on comedi driver and thus improves readability. Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: comedi (me4000): use PCI_DEVICE() macroJavier Martinez Canillas2010-08-311-15/+14
| | | | | | | Use PCI_DEVICE() macro for pci table entries on comedi driver and thus improves readability. Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: comedi (cb_pcimdas): use PCI_DEVICE() macroJavier Martinez Canillas2010-08-311-4/+2
| | | | | | | Use PCI_DEVICE() macro for pci table entries on comedi driver and thus improves readability. Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: comedi (adv_pci_dio): use PCI_DEVICE() macroJavier Martinez Canillas2010-08-311-15/+14
| | | | | | | Use PCI_DEVICE() macro for pci table entries on comedi driver and thus improves readability. Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: comedi (adl_pci6208): use PCI_DEVICE() macroJavier Martinez Canillas2010-08-311-3/+2
| | | | | | | Use PCI_DEVICE() macro for pci table entries on comedi driver and thus improves readability. Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: comedi (adl_pci9118): use PCI_DEVICE() macroJavier Martinez Canillas2010-08-311-3/+2
| | | | | | | Use PCI_DEVICE() macro for pci table entries on comedi driver and thus improves readability. Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: comedi (skel): use PCI_DEVICE() macroJavier Martinez Canillas2010-08-311-4/+3
| | | | | | | Use PCI_DEVICE() macro for pci table entries on comedi driver and thus improves readability. Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: comedi (adv_pci1710): use PCI_DEVICE() macroJavier Martinez Canillas2010-08-311-7/+6
| | | | | | | Use PCI_DEVICE() macro for pci table entries on comedi driver and thus improves readability. Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: comedi (adv_pci1723): use PCI_DEVICE() macroJavier Martinez Canillas2010-08-311-3/+2
| | | | | | | Use PCI_DEVICE() macro for pci table entries on comedi driver and thus improves readability. Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>