aboutsummaryrefslogtreecommitdiffstats
path: root/tools/perf
diff options
context:
space:
mode:
authorArnaldo Carvalho de Melo <acme@redhat.com>2010-08-02 18:59:28 -0300
committerArnaldo Carvalho de Melo <acme@redhat.com>2010-08-02 19:01:09 -0300
commit70597f21f128b7dd6a2490078bea99d704b6f8c3 (patch)
tree33ed9836a3c6e2c111f60746ce1769c9eba42bd7 /tools/perf
parent076c6e45215aea0de1ed34d3d5079fabeaabf5e1 (diff)
downloadmrst-s0i3-test-70597f21f128b7dd6a2490078bea99d704b6f8c3.tar.gz
mrst-s0i3-test-70597f21f128b7dd6a2490078bea99d704b6f8c3.tar.xz
mrst-s0i3-test-70597f21f128b7dd6a2490078bea99d704b6f8c3.zip
perf session: Invalidate last_match when removing threads from rb_tree
If we receive two PERF_RECORD_EXIT for the same thread, we can end up reusing session->last_match and trying to remove the thread twice from the rb_tree, causing a segfault, so invalidade last_match in perf_session__remove_thread. Receiving two PERF_RECORD_EXIT for the same thread is a bug, but its a harmless one if we make the tool more robust, like this patch does. Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Mike Galbraith <efault@gmx.de> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Stephane Eranian <eranian@google.com> LKML-Reference: <new-submission> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf')
-rw-r--r--tools/perf/util/session.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
index 5d2fd52fe7b..fa9d652c2dc 100644
--- a/tools/perf/util/session.c
+++ b/tools/perf/util/session.c
@@ -166,6 +166,7 @@ void perf_session__delete(struct perf_session *self)
void perf_session__remove_thread(struct perf_session *self, struct thread *th)
{
+ self->last_match = NULL;
rb_erase(&th->rb_node, &self->threads);
/*
* We may have references to this thread, for instance in some hist_entry