aboutsummaryrefslogtreecommitdiffstats
path: root/sound
diff options
context:
space:
mode:
authorTakashi Iwai <tiwai@suse.de>2010-09-08 08:27:02 +0200
committerTakashi Iwai <tiwai@suse.de>2010-09-08 08:27:02 +0200
commit76195fb096ca6db2f8bbaffb96e3025aaf1649a0 (patch)
tree695e9030c4d07cee2a6db66f431d6997ec9071e7 /sound
parentfe6ce80ae25953d95ebaf9bce27b585218cda25c (diff)
downloadmrst-s0i3-test-76195fb096ca6db2f8bbaffb96e3025aaf1649a0.tar.gz
mrst-s0i3-test-76195fb096ca6db2f8bbaffb96e3025aaf1649a0.tar.xz
mrst-s0i3-test-76195fb096ca6db2f8bbaffb96e3025aaf1649a0.zip
ALSA: usb - Release capture substream URBs properly
Due to the wrong "return" in the loop, a capture substream won't be released at disconnection properly if the device is capture only and has no playback substream. This caused Oops occasionally at the device reconnection. Reported-by: Kim Minhyoung <minhyoung.kim@lge.com> Cc: <stable@kernel.org> Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound')
-rw-r--r--sound/usb/card.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/usb/card.c b/sound/usb/card.c
index 32e4be8a187..4eabafa5b03 100644
--- a/sound/usb/card.c
+++ b/sound/usb/card.c
@@ -126,7 +126,7 @@ static void snd_usb_stream_disconnect(struct list_head *head)
for (idx = 0; idx < 2; idx++) {
subs = &as->substream[idx];
if (!subs->num_formats)
- return;
+ continue;
snd_usb_release_substream_urbs(subs, 1);
subs->interface = -1;
}