|author||Mark Brown <firstname.lastname@example.org>||2010-01-15 17:01:40 -0800|
|committer||Linus Torvalds <email@example.com>||2010-01-16 12:15:40 -0800|
revert "drivers/video/s3c-fb.c: fix clock setting for Samsung SoC Framebuffer"
Fix divide by zero and broken output. Commit 600ce1a0fa ("fix clock setting for Samsung SoC Framebuffer") introduced a mandatory refresh parameter to the platform data for the S3C framebuffer but did not introduce any validation code, causing existing platforms (none of which have refresh set) to divide by zero whenever the framebuffer is configured, generating warnings and unusable output. Ben Dooks noted several problems with the patch: - The platform data supplies the pixclk directly and should already have taken care of the refresh rate. - The addition of a window ID parameter doesn't help since only the root framebuffer can control the pixclk. - pixclk is specified in picoseconds (rather than Hz) as the patch assumed. and suggests reverting the commit so do that. Without fixing this no mainline user of the driver will produce output. [firstname.lastname@example.org: don't revert the correct bit] Signed-off-by: Mark Brown <email@example.com> Cc: InKi Dae <firstname.lastname@example.org> Cc: Kyungmin Park <email@example.com> Cc: Krzysztof Helt <firstname.lastname@example.org> Cc: Marek Szyprowski <email@example.com> Cc: Ben Dooks <firstname.lastname@example.org> Cc: <email@example.com> Signed-off-by: Andrew Morton <firstname.lastname@example.org> Signed-off-by: Linus Torvalds <email@example.com>
Diffstat (limited to 'scripts')
0 files changed, 0 insertions, 0 deletions