path: root/net
diff options
authorEric Paris <eparis@redhat.com>2010-11-12 08:26:06 +0100
committerPatrick McHardy <kaber@trash.net>2010-11-12 08:26:06 +0100
commitac5aa2e3332ec04889074afdbd1479424d0227a5 (patch)
treef530e53b434f2ebcd89e93103d1e98aa41b2d372 /net
parentb5f15ac4f89f84853544c934fc7a744289e95e34 (diff)
netfilter: NF_HOOK_COND has wrong conditional
The NF_HOOK_COND returns 0 when it shouldn't due to what I believe to be an error in the code as the order of operations is not what was intended. C will evalutate == before =. Which means ret is getting set to the bool result, rather than the return value of the function call. The code says if (ret = function() == 1) when it meant to say: if ((ret = function()) == 1) Normally the compiler would warn, but it doesn't notice it because its a actually complex conditional and so the wrong code is wrapped in an explict set of () [exactly what the compiler wants you to do if this was intentional]. Fixing this means that errors when netfilter denies a packet get propagated back up the stack rather than lost. Problem introduced by commit 2249065f (netfilter: get rid of the grossness in netfilter.h). Signed-off-by: Eric Paris <eparis@redhat.com> Cc: stable@kernel.org Signed-off-by: Patrick McHardy <kaber@trash.net>
Diffstat (limited to 'net')
0 files changed, 0 insertions, 0 deletions