aboutsummaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorDavid S. Miller <davem@davemloft.net>2010-09-12 11:56:44 -0700
committerDavid S. Miller <davem@davemloft.net>2010-09-12 11:56:44 -0700
commita505b3b30fc69904f858822a2aa95990a4bf7958 (patch)
tree4ea708f794d8cb91f77d42e32fce5324902cc274 /net
parent053d8f6622701f849fda2ca2c9ae596c13599ba9 (diff)
downloadmrst-s0i3-test-a505b3b30fc69904f858822a2aa95990a4bf7958.tar.gz
mrst-s0i3-test-a505b3b30fc69904f858822a2aa95990a4bf7958.tar.xz
mrst-s0i3-test-a505b3b30fc69904f858822a2aa95990a4bf7958.zip
sch_atm: Fix potential NULL deref.
The list_head conversion unearther an unnecessary flow check. Since flow is always NULL here we don't need to see if a matching flow exists already. Reported-by: Jiri Slaby <jirislaby@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
-rw-r--r--net/sched/sch_atm.c4
1 files changed, 0 insertions, 4 deletions
diff --git a/net/sched/sch_atm.c b/net/sched/sch_atm.c
index 34066278952..6318e1136b8 100644
--- a/net/sched/sch_atm.c
+++ b/net/sched/sch_atm.c
@@ -255,10 +255,6 @@ static int atm_tc_change(struct Qdisc *sch, u32 classid, u32 parent,
error = -EINVAL;
goto err_out;
}
- if (!list_empty(&flow->list)) {
- error = -EEXIST;
- goto err_out;
- }
} else {
int i;
unsigned long cl;