aboutsummaryrefslogtreecommitdiffstats
path: root/kernel
diff options
context:
space:
mode:
authorThomas Gleixner <tglx@linutronix.de>2010-10-22 14:47:57 +0200
committerThomas Gleixner <tglx@linutronix.de>2010-10-22 16:10:29 +0200
commit2656c36699677238edc9ec1fea79039f1fddbcb6 (patch)
tree4fd8b68709598b5c581b3792ad2fc7481be76e12 /kernel
parentd4429f608abde89e8bc1e24b43cd503feb95c496 (diff)
downloadmrst-s0i3-test-2656c36699677238edc9ec1fea79039f1fddbcb6.tar.gz
mrst-s0i3-test-2656c36699677238edc9ec1fea79039f1fddbcb6.tar.xz
mrst-s0i3-test-2656c36699677238edc9ec1fea79039f1fddbcb6.zip
genirq: Warn if enable_irq is called before irq is set up
The recent changes in the genirq core unearthed a bug in arch/um which called enable_irq() before the interrupt was set up. Warn and return instead of crashing the machine with a NULL pointer dereference. Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Richard Weinberger <richard@nod.at>
Diffstat (limited to 'kernel')
-rw-r--r--kernel/irq/manage.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index 644e8d5fa36..5f92acc5f95 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -324,6 +324,10 @@ void enable_irq(unsigned int irq)
if (!desc)
return;
+ if (WARN(!desc->irq_data.chip || !desc->irq_data.chip->irq_enable,
+ KERN_ERR "enable_irq before setup/request_irq: irq %u\n", irq))
+ return;
+
chip_bus_lock(desc);
raw_spin_lock_irqsave(&desc->lock, flags);
__enable_irq(desc, irq, false);