aboutsummaryrefslogtreecommitdiffstats
path: root/init/Kconfig
diff options
context:
space:
mode:
authorMasami Hiramatsu <mhiramat@redhat.com>2010-01-08 14:42:38 -0800
committerLinus Torvalds <torvalds@linux-foundation.org>2010-01-11 09:34:04 -0800
commit8767ba2796a1c894e6d9524584a26a8224f0543d (patch)
treecefe04f3420ae11d46c4badbd1d3b2993da156b7 /init/Kconfig
parent42d53b4ff7d61487d18274ebdf1f70c1aef6f122 (diff)
downloadmrst-s0i3-test-8767ba2796a1c894e6d9524584a26a8224f0543d.tar.gz
mrst-s0i3-test-8767ba2796a1c894e6d9524584a26a8224f0543d.tar.xz
mrst-s0i3-test-8767ba2796a1c894e6d9524584a26a8224f0543d.zip
kmod: fix resource leak in call_usermodehelper_pipe()
Fix resource (write-pipe file) leak in call_usermodehelper_pipe(). When call_usermodehelper_exec() fails, write-pipe file is opened and call_usermodehelper_pipe() just returns an error. Since it is hard for caller to determine whether the error occured when opening the pipe or executing the helper, the caller cannot close the pipe by themselves. I've found this resoruce leak when testing coredump. You can check how the resource leaks as below; $ echo "|nocommand" > /proc/sys/kernel/core_pattern $ ulimit -c unlimited $ while [ 1 ]; do ./segv; done &> /dev/null & $ cat /proc/meminfo (<- repeat it) where segv.c is; //----- int main () { char *p = 0; *p = 1; } //----- This patch closes write-pipe file if call_usermodehelper_exec() failed. Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com> Cc: Rusty Russell <rusty@rustcorp.com.au> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'init/Kconfig')
0 files changed, 0 insertions, 0 deletions