aboutsummaryrefslogtreecommitdiffstats
path: root/include/mtd/mtd-abi.h
diff options
context:
space:
mode:
authorBrian Norris <computersforpeace@gmail.com>2010-09-19 23:57:12 -0700
committerDavid Woodhouse <David.Woodhouse@intel.com>2010-10-24 23:37:27 +0100
commit0ceacf36e9c41859a6072342d27cf6e60776c523 (patch)
treed2495228b90bc94c7ebd7209d82310e5d72ec723 /include/mtd/mtd-abi.h
parentcc26c3cd3d1cf40a07f2b19ac4c53d517bee52a5 (diff)
downloadmrst-s0i3-test-0ceacf36e9c41859a6072342d27cf6e60776c523.tar.gz
mrst-s0i3-test-0ceacf36e9c41859a6072342d27cf6e60776c523.tar.xz
mrst-s0i3-test-0ceacf36e9c41859a6072342d27cf6e60776c523.zip
mtd: edit comments on deprecation of ioctl ECCGETLAYOUT
There were some improvements and additions necessary in the comments explaining of the expansion of nand_ecclayout, the introduction of nand_ecclayout_user, and the deprecation of the ioctl ECCGETLAYOUT. Also, I found a better placement for the macro MTD_MAX_ECCPOS_ENTRIES; next to the definition of MTD_MAX_OOBFREE_ENTRIES in mtd-abi.h. The macro is really only important for the ioctl code (found in drivers/mtd/mtdchar.c) but since there are small edits being made to the user-space header, I figured this is a better location. Signed-off-by: Brian Norris <computersforpeace@gmail.com> Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
Diffstat (limited to 'include/mtd/mtd-abi.h')
-rw-r--r--include/mtd/mtd-abi.h11
1 files changed, 8 insertions, 3 deletions
diff --git a/include/mtd/mtd-abi.h b/include/mtd/mtd-abi.h
index 5bce0838434..a57c4cb7d6b 100644
--- a/include/mtd/mtd-abi.h
+++ b/include/mtd/mtd-abi.h
@@ -144,13 +144,18 @@ struct nand_oobfree {
};
#define MTD_MAX_OOBFREE_ENTRIES 8
+#define MTD_MAX_ECCPOS_ENTRIES 64
/*
- * ECC layout control structure. Exported to userspace for
- * diagnosis and to allow creation of raw images
+ * OBSOLETE: ECC layout control structure. Exported to user-space via ioctl
+ * ECCGETLAYOUT for backwards compatbility and should not be mistaken as a
+ * complete set of ECC information. The ioctl truncates the larger internal
+ * structure to retain binary compatibility with the static declaration of the
+ * ioctl. Note that the "MTD_MAX_..._ENTRIES" macros represent the max size of
+ * the user struct, not the MAX size of the internal struct nand_ecclayout.
*/
struct nand_ecclayout_user {
__u32 eccbytes;
- __u32 eccpos[64];
+ __u32 eccpos[MTD_MAX_ECCPOS_ENTRIES];
__u32 oobavail;
struct nand_oobfree oobfree[MTD_MAX_OOBFREE_ENTRIES];
};