aboutsummaryrefslogtreecommitdiffstats
path: root/include/linux/lcm.h
diff options
context:
space:
mode:
authorMartin K. Petersen <martin.petersen@oracle.com>2010-03-15 12:46:51 +0100
committerJens Axboe <jens.axboe@oracle.com>2010-03-15 12:47:59 +0100
commit2cda2728aa1c8c006418a24f867b25e5eb7a32e2 (patch)
treec23ec7c38d74237646c5453d96bfbbea4cadfee7 /include/linux/lcm.h
parentf11c9c5c259cb2c3d698548dc3936f773ab1f5b9 (diff)
downloadmrst-s0i3-test-2cda2728aa1c8c006418a24f867b25e5eb7a32e2.tar.gz
mrst-s0i3-test-2cda2728aa1c8c006418a24f867b25e5eb7a32e2.tar.xz
mrst-s0i3-test-2cda2728aa1c8c006418a24f867b25e5eb7a32e2.zip
block: Fix overrun in lcm() and move it to lib
lcm() was defined to take integer-sized arguments. The supplied arguments are multiplied, however, causing us to overflow given sufficiently large input. That in turn led to incorrect optimal I/O size reporting in some cases (RAID over RAID). Switch lcm() over to unsigned long similar to gcd() and move the function from blk-settings.c to lib. Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
Diffstat (limited to 'include/linux/lcm.h')
-rw-r--r--include/linux/lcm.h8
1 files changed, 8 insertions, 0 deletions
diff --git a/include/linux/lcm.h b/include/linux/lcm.h
new file mode 100644
index 00000000000..7bf01d779b4
--- /dev/null
+++ b/include/linux/lcm.h
@@ -0,0 +1,8 @@
+#ifndef _LCM_H
+#define _LCM_H
+
+#include <linux/compiler.h>
+
+unsigned long lcm(unsigned long a, unsigned long b) __attribute_const__;
+
+#endif /* _LCM_H */