aboutsummaryrefslogtreecommitdiffstats
path: root/fs/anon_inodes.c
diff options
context:
space:
mode:
authorAl Viro <viro@zeniv.linux.org.uk>2009-12-19 10:15:07 -0500
committerAl Viro <viro@zeniv.linux.org.uk>2009-12-22 12:27:34 -0500
commit5300990c0370e804e49d9a59d928c5d53fb73487 (patch)
tree08ed922afd172662039c082ec9e9410070f4afe8 /fs/anon_inodes.c
parent482928d59db668b8d82a48717f78986d8cea72e9 (diff)
downloadmrst-s0i3-test-5300990c0370e804e49d9a59d928c5d53fb73487.tar.gz
mrst-s0i3-test-5300990c0370e804e49d9a59d928c5d53fb73487.tar.xz
mrst-s0i3-test-5300990c0370e804e49d9a59d928c5d53fb73487.zip
Sanitize f_flags helpers
* pull ACC_MODE to fs.h; we have several copies all over the place * nightmarish expression calculating f_mode by f_flags deserves a helper too (OPEN_FMODE(flags)) Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/anon_inodes.c')
-rw-r--r--fs/anon_inodes.c10
1 files changed, 1 insertions, 9 deletions
diff --git a/fs/anon_inodes.c b/fs/anon_inodes.c
index 598237e9722..9f0bf13291e 100644
--- a/fs/anon_inodes.c
+++ b/fs/anon_inodes.c
@@ -89,19 +89,11 @@ struct file *anon_inode_getfile(const char *name,
struct qstr this;
struct path path;
struct file *file;
- fmode_t mode;
int error;
if (IS_ERR(anon_inode_inode))
return ERR_PTR(-ENODEV);
- switch (flags & O_ACCMODE) {
- case O_RDONLY: mode = FMODE_READ; break;
- case O_WRONLY: mode = FMODE_WRITE; break;
- case O_RDWR: mode = FMODE_READ | FMODE_WRITE; break;
- default: return ERR_PTR(-EINVAL);
- }
-
if (fops->owner && !try_module_get(fops->owner))
return ERR_PTR(-ENOENT);
@@ -129,7 +121,7 @@ struct file *anon_inode_getfile(const char *name,
d_instantiate(path.dentry, anon_inode_inode);
error = -ENFILE;
- file = alloc_file(&path, mode, fops);
+ file = alloc_file(&path, OPEN_FMODE(flags), fops);
if (!file)
goto err_dput;
file->f_mapping = anon_inode_inode->i_mapping;