aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/scsi/libfc
diff options
context:
space:
mode:
authorYi Zou <yi.zou@intel.com>2010-04-09 14:23:05 -0700
committerJames Bottomley <James.Bottomley@suse.de>2010-04-11 14:02:40 -0500
commit63ac4bbffb40f2cb3bc7e8b11bac47598813ea13 (patch)
tree1b0abf1576e58549f3a89e218e3ab67e55f205e1 /drivers/scsi/libfc
parentda87bfab8a7e6cfd0e1e5c5874d7fd4f7d11e64e (diff)
downloadmrst-s0i3-test-63ac4bbffb40f2cb3bc7e8b11bac47598813ea13.tar.gz
mrst-s0i3-test-63ac4bbffb40f2cb3bc7e8b11bac47598813ea13.tar.xz
mrst-s0i3-test-63ac4bbffb40f2cb3bc7e8b11bac47598813ea13.zip
[SCSI] libfc: bug in erroring out upon FCP_RSP_LEN_VAL in fc_fcp_resp
fc_fcp_resp is assuming when FCP_SNS_LEN_VAL is set, the FCP_RSP_LEN_VAL is not, which is not true. This leads to not copying the sense data and error out a valid FCP_RSP. Signed-off-by: Yi Zou <yi.zou@intel.com> Signed-off-by: Robert Love <robert.w.love@intel.com> Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Diffstat (limited to 'drivers/scsi/libfc')
-rw-r--r--drivers/scsi/libfc/fc_fcp.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/scsi/libfc/fc_fcp.c b/drivers/scsi/libfc/fc_fcp.c
index 220c4bc536c..f99d66fa2ef 100644
--- a/drivers/scsi/libfc/fc_fcp.c
+++ b/drivers/scsi/libfc/fc_fcp.c
@@ -844,8 +844,7 @@ static void fc_fcp_resp(struct fc_fcp_pkt *fsp, struct fc_frame *fp)
* exit here
*/
return;
- } else
- goto err;
+ }
}
if (flags & FCP_SNS_LEN_VAL) {
snsl = ntohl(rp_ex->fr_sns_len);