aboutsummaryrefslogtreecommitdiffstats
path: root/block
diff options
context:
space:
mode:
authorwzt.wzt@gmail.com <wzt.wzt@gmail.com>2010-04-02 08:41:14 +0200
committerJens Axboe <jens.axboe@oracle.com>2010-04-02 08:41:14 +0200
commita506aedc51093544ff0f9610af6066d18cb6abbe (patch)
tree3a23d5987c02a94eb46746ae29d50d2d9e38a150 /block
parentb2b163dd47024e445410b72d0c5df6d819c14dfd (diff)
downloadmrst-s0i3-test-a506aedc51093544ff0f9610af6066d18cb6abbe.tar.gz
mrst-s0i3-test-a506aedc51093544ff0f9610af6066d18cb6abbe.tar.xz
mrst-s0i3-test-a506aedc51093544ff0f9610af6066d18cb6abbe.zip
Block: Fix block/elevator.c elevator_get() off-by-one error
elevator_get() not check the name length, if the name length > sizeof(elv), elv will miss the '\0'. And elv buffer will be replace "-iosched" as something like aaaaaaaaa, then call request_module() can load an not trust module. Signed-off-by: Zhitong Wang <zhitong.wangzt@alibaba-inc.com> Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
Diffstat (limited to 'block')
-rw-r--r--block/elevator.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/block/elevator.c b/block/elevator.c
index df75676f667..76e3702d538 100644
--- a/block/elevator.c
+++ b/block/elevator.c
@@ -154,7 +154,7 @@ static struct elevator_type *elevator_get(const char *name)
spin_unlock(&elv_list_lock);
- sprintf(elv, "%s-iosched", name);
+ snprintf(elv, sizeof(elv), "%s-iosched", name);
request_module("%s", elv);
spin_lock(&elv_list_lock);