aboutsummaryrefslogtreecommitdiffstats
path: root/Documentation
diff options
context:
space:
mode:
authorDan Carpenter <error27@gmail.com>2010-11-18 12:27:32 -0800
committerLinus Torvalds <torvalds@linux-foundation.org>2010-11-18 15:00:46 -0800
commit09c9feb94672bdb3ca6d424a292ffc26eff8ca0b (patch)
treee73e487f5b89de79c62ae784f0eda0721bc8f3c1 /Documentation
parent2b35f4d9cab365d37c7b34ce51e1c1144c312d05 (diff)
downloadmrst-s0i3-test-09c9feb94672bdb3ca6d424a292ffc26eff8ca0b.tar.gz
mrst-s0i3-test-09c9feb94672bdb3ca6d424a292ffc26eff8ca0b.tar.xz
mrst-s0i3-test-09c9feb94672bdb3ca6d424a292ffc26eff8ca0b.zip
Documentation: make configfs example code simpler, clearer
If "p" is NULL then it will cause an oops when we pass it to simple_strtoul(). In this case "p" can not be NULL so I removed the check. I also changed the check a little to make it more explicit that we are testing whether p points to the NUL char. Signed-off-by: Dan Carpenter <error27@gmail.com> Acked-by: Joel Becker <joel.becker@oracle.com> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'Documentation')
-rw-r--r--Documentation/filesystems/configfs/configfs_example_explicit.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/Documentation/filesystems/configfs/configfs_example_explicit.c b/Documentation/filesystems/configfs/configfs_example_explicit.c
index d428cc9f07f..fd53869f563 100644
--- a/Documentation/filesystems/configfs/configfs_example_explicit.c
+++ b/Documentation/filesystems/configfs/configfs_example_explicit.c
@@ -89,7 +89,7 @@ static ssize_t childless_storeme_write(struct childless *childless,
char *p = (char *) page;
tmp = simple_strtoul(p, &p, 10);
- if (!p || (*p && (*p != '\n')))
+ if ((*p != '\0') && (*p != '\n'))
return -EINVAL;
if (tmp > INT_MAX)