aboutsummaryrefslogtreecommitdiffstats
path: root/Documentation
diff options
context:
space:
mode:
authorAxel Lin <axel.lin@gmail.com>2010-09-06 16:48:13 +0800
committerLiam Girdwood <lrg@slimlogic.co.uk>2010-09-06 11:14:47 +0100
commite260999c66768c2fccd9da8c3918b4e0e5121b3a (patch)
tree008282c9827755d9b2fb493422e00c8a4d3ae0d4 /Documentation
parent49990e6efe576b8707584398f93198b5aa182ab7 (diff)
downloadmrst-s0i3-test-e260999c66768c2fccd9da8c3918b4e0e5121b3a.tar.gz
mrst-s0i3-test-e260999c66768c2fccd9da8c3918b4e0e5121b3a.tar.xz
mrst-s0i3-test-e260999c66768c2fccd9da8c3918b4e0e5121b3a.zip
regulator: wm831x-ldo - fix the logic to set REGULATOR_MODE_IDLE and REGULATOR_MODE_STANDBY modes
Problem description in current implementation: When setting REGULATOR_MODE_IDLE mode, current implementation set WM831X_LDO1_LP_MODE bit of ctrl_reg (which is wrong, it should clear the bit). But due to a missing break statement for case REGULATOR_MODE_IDLE, the code fall through to case REGULATOR_MODE_STANDBY and then clear WM831X_LDO1_LP_MODE bit. So it still looks OK when checking the status by wm831x_gp_ldo_get_mode(). When setting REGULATOR_MODE_STANDBY mode, it just does not work. wm831x_gp_ldo_get_mode() will still return REGULATOR_MODE_IDLE because the accordingly WM831X_LDO1_LP_MODE bit is clear. Correct behavior should be: Clear WM831X_LDO1_LP_MODE bit of ctrl_reg for REGULATOR_MODE_IDLE mode. Set WM831X_LDO1_LP_MODE bit of ctrl_reg for REGULATOR_MODE_STANDBY mode. Signed-off-by: Axel Lin <axel.lin@gmail.com> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com> Signed-off-by: Liam Girdwood <lrg@slimlogic.co.uk>
Diffstat (limited to 'Documentation')
0 files changed, 0 insertions, 0 deletions