aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorArnaldo Carvalho de Melo <acme@redhat.com>2009-12-28 22:48:35 -0200
committerIngo Molnar <mingo@elte.hu>2009-12-30 11:59:59 +0100
commitcdbae31408cf39372402076cf2e189ec693daa71 (patch)
tree95b8eaf8b90ef6b5ef6bf8db548ee80cc11ec300
parent71289be7630fb97f2de6bb2e18a50289dc869f9d (diff)
downloadmrst-s0i3-test-cdbae31408cf39372402076cf2e189ec693daa71.tar.gz
mrst-s0i3-test-cdbae31408cf39372402076cf2e189ec693daa71.tar.xz
mrst-s0i3-test-cdbae31408cf39372402076cf2e189ec693daa71.zip
perf diff: Don't add the period for unresolved symbols
Since we don't add histograms buckets for them, this way the sum of baselines should be 100%. Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> Cc: Frédéric Weisbecker <fweisbec@gmail.com> Cc: Mike Galbraith <efault@gmx.de> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Paul Mackerras <paulus@samba.org> LKML-Reference: <1262047716-23171-4-git-send-email-acme@infradead.org> Signed-off-by: Ingo Molnar <mingo@elte.hu>
-rw-r--r--tools/perf/builtin-diff.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c
index 1cbecaf029f..876a4b981be 100644
--- a/tools/perf/builtin-diff.c
+++ b/tools/perf/builtin-diff.c
@@ -51,12 +51,12 @@ static int diff__process_sample_event(event_t *event, struct perf_session *sessi
return -1;
}
- if (al.filtered)
+ if (al.filtered || al.sym == NULL)
return 0;
event__parse_sample(event, session->sample_type, &data);
- if (al.sym && perf_session__add_hist_entry(session, &al, data.period)) {
+ if (perf_session__add_hist_entry(session, &al, data.period)) {
pr_warning("problem incrementing symbol count, skipping event\n");
return -1;
}