aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDaniel Drake <dsd@laptop.org>2010-11-14 14:12:31 +0000
committerPaul Mundt <lethal@linux-sh.org>2010-11-17 14:55:46 +0900
commitad913da61aeb267ac99a649834a0cb1a963d7ec2 (patch)
treef5efa0c8b940b8b50a05d580e58569e85dd28962
parent1e7c7804884fc5751e3872f13498fd533325f8b2 (diff)
downloadmrst-s0i3-test-ad913da61aeb267ac99a649834a0cb1a963d7ec2.tar.gz
mrst-s0i3-test-ad913da61aeb267ac99a649834a0cb1a963d7ec2.tar.xz
mrst-s0i3-test-ad913da61aeb267ac99a649834a0cb1a963d7ec2.zip
lxfb: Program panel v/h sync output polarity correctly
Commit b5c26f97ec4a17c65 introduced some breakage for the OLPC XO-1 laptop, differences in the output video signal after the patch caused some problems with the XO's display controller chip. Reviewing of that commit against the AMD Geode LX Data Book, it seems that these bits were being set inversely. In both cases, active high output is denoted by a value of 0. See section 6.8.3.44 of the databook from February 2009 (Publication ID: 33234H) Signed-off-by: Daniel Drake <dsd@laptop.org> Signed-off-by: Paul Mundt <lethal@linux-sh.org>
-rw-r--r--drivers/video/geode/lxfb_ops.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/video/geode/lxfb_ops.c b/drivers/video/geode/lxfb_ops.c
index bc35a95e59d..85ec7f64c42 100644
--- a/drivers/video/geode/lxfb_ops.c
+++ b/drivers/video/geode/lxfb_ops.c
@@ -276,10 +276,10 @@ static void lx_graphics_enable(struct fb_info *info)
write_fp(par, FP_PT1, 0);
temp = FP_PT2_SCRC;
- if (info->var.sync & FB_SYNC_HOR_HIGH_ACT)
+ if (!(info->var.sync & FB_SYNC_HOR_HIGH_ACT))
temp |= FP_PT2_HSP;
- if (info->var.sync & FB_SYNC_VERT_HIGH_ACT)
+ if (!(info->var.sync & FB_SYNC_VERT_HIGH_ACT))
temp |= FP_PT2_VSP;
write_fp(par, FP_PT2, temp);