aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSonic Zhang <sonic.zhang@analog.com>2009-05-29 03:40:43 +0000
committerDavid S. Miller <davem@davemloft.net>2009-05-29 15:49:08 -0700
commit805a8ab3ce1be83e9a98c21a625ebbb549a2d317 (patch)
treea52e5273d1e1ba281695808186fddfa07436722c
parent91a455f089810625eb94a36ccc40ae963f451b06 (diff)
downloadmrst-s0i3-test-805a8ab3ce1be83e9a98c21a625ebbb549a2d317.tar.gz
mrst-s0i3-test-805a8ab3ce1be83e9a98c21a625ebbb549a2d317.tar.xz
mrst-s0i3-test-805a8ab3ce1be83e9a98c21a625ebbb549a2d317.zip
netdev: bfin_mac: fix malformed UDP packet transmission when polling with KGDB
Writes to the DMA descriptors may sit in the internal Blackfin data buffers and not actually be available when the DMA engine goes to fetch them. This does not typically happen, but when dealing with short/fast packets such as UDP and polling KGDB, this occurs much more frequently. Same goes for heavy loads as seen by netperf tests or large scp transfers. So force the buffers to drain with SSYNC otherwise we get random malformed packets. Signed-off-by: Sonic Zhang <sonic.zhang@analog.com> Signed-off-by: Mike Frysinger <vapier@gentoo.org> Signed-off-by: Bryan Wu <cooloney@kernel.org> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/bfin_mac.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/drivers/net/bfin_mac.c b/drivers/net/bfin_mac.c
index 1905532d094..38d34cec65a 100644
--- a/drivers/net/bfin_mac.c
+++ b/drivers/net/bfin_mac.c
@@ -688,6 +688,12 @@ static int bfin_mac_hard_start_xmit(struct sk_buff *skb,
}
}
+ /* make sure the internal data buffers in the core are drained
+ * so that the DMA descriptors are completely written when the
+ * DMA engine goes to fetch them below
+ */
+ SSYNC();
+
/* enable this packet's dma */
current_tx_ptr->desc_a.config |= DMAEN;