aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHannes Reinecke <hare@suse.de>2010-05-04 16:49:21 +0200
committerJames Bottomley <James.Bottomley@suse.de>2010-05-05 12:13:26 -0400
commitc213e1407be6b04b144794399a91472e0ef92aec (patch)
tree008bd8d7c0840c29bac8bf159850ab317043c4eb
parent5447ed6c968e7270b656afa273c2b79d15d82edd (diff)
downloadmrst-s0i3-test-c213e1407be6b04b144794399a91472e0ef92aec.tar.gz
mrst-s0i3-test-c213e1407be6b04b144794399a91472e0ef92aec.tar.xz
mrst-s0i3-test-c213e1407be6b04b144794399a91472e0ef92aec.zip
[SCSI] Enable retries for SYNCRONIZE_CACHE commands to fix I/O error
Some arrays are giving I/O errors with ext3 filesystems when SYNCHRONIZE_CACHE gets a UNIT_ATTENTION. What is happening is that these commands have no retries, so the UNIT_ATTENTION causes the barrier to fail. We should be enable retries here to clear any transient error and allow the barrier to succeed. Signed-off-by: Hannes Reinecke <hare@suse.de> Cc: Stable Tree <stable@kernel.org> Signed-off-by: James Bottomley <James.Bottomley@suse.de>
-rw-r--r--drivers/scsi/sd.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 8b827f37b03..de6c60320f6 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -1040,6 +1040,7 @@ static void sd_prepare_flush(struct request_queue *q, struct request *rq)
{
rq->cmd_type = REQ_TYPE_BLOCK_PC;
rq->timeout = SD_TIMEOUT;
+ rq->retries = SD_MAX_RETRIES;
rq->cmd[0] = SYNCHRONIZE_CACHE;
rq->cmd_len = 10;
}