aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStephen Hemminger <shemminger@linux-foundation.org>2007-03-22 12:16:21 -0700
committerDavid S. Miller <davem@sunset.davemloft.net>2007-04-25 22:27:20 -0700
commitb407621c35ed5f9a0734e57472e9539117963768 (patch)
treeff38bcb206b20ebbc3c3f289bdce8ff7eb42f2f4
parenta362e0a7890c735a3ef63aab12d71ecfc6e6f4a5 (diff)
downloadmrst-s0i3-test-b407621c35ed5f9a0734e57472e9539117963768.tar.gz
mrst-s0i3-test-b407621c35ed5f9a0734e57472e9539117963768.tar.xz
mrst-s0i3-test-b407621c35ed5f9a0734e57472e9539117963768.zip
[NETEM]: use better types for time values
The random number generator always generates 32 bit values. The time values are limited by psched_tdiff_t Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/sched/sch_netem.c21
1 files changed, 12 insertions, 9 deletions
diff --git a/net/sched/sch_netem.c b/net/sched/sch_netem.c
index 791c615e3aa..4ac6df0a5b3 100644
--- a/net/sched/sch_netem.c
+++ b/net/sched/sch_netem.c
@@ -57,19 +57,20 @@ struct netem_sched_data {
struct Qdisc *qdisc;
struct qdisc_watchdog watchdog;
- u32 latency;
+ psched_tdiff_t latency;
+ psched_tdiff_t jitter;
+
u32 loss;
u32 limit;
u32 counter;
u32 gap;
- u32 jitter;
u32 duplicate;
u32 reorder;
u32 corrupt;
struct crndstate {
- unsigned long last;
- unsigned long rho;
+ u32 last;
+ u32 rho;
} delay_cor, loss_cor, dup_cor, reorder_cor, corrupt_cor;
struct disttable {
@@ -96,7 +97,7 @@ static void init_crandom(struct crndstate *state, unsigned long rho)
* Next number depends on last value.
* rho is scaled to avoid floating point.
*/
-static unsigned long get_crandom(struct crndstate *state)
+static u32 get_crandom(struct crndstate *state)
{
u64 value, rho;
unsigned long answer;
@@ -115,11 +116,13 @@ static unsigned long get_crandom(struct crndstate *state)
* std deviation sigma. Uses table lookup to approximate the desired
* distribution, and a uniformly-distributed pseudo-random source.
*/
-static long tabledist(unsigned long mu, long sigma,
- struct crndstate *state, const struct disttable *dist)
+static psched_tdiff_t tabledist(psched_tdiff_t mu, psched_tdiff_t sigma,
+ struct crndstate *state,
+ const struct disttable *dist)
{
- long t, x;
- unsigned long rnd;
+ psched_tdiff_t x;
+ long t;
+ u32 rnd;
if (sigma == 0)
return mu;