aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVasiliy Kulikov <segoon@openwall.com>2010-11-18 10:35:58 -0800
committerDavid S. Miller <davem@davemloft.net>2010-11-18 10:35:58 -0800
commit8ea91226eccf6c8ab9c55054b24c21021d4d9d19 (patch)
tree70fd9d9479d09c1dcf7d97264ebc03fd66e9cc11
parent7d8e76bf9ac3604897f0ce12e8bf09b68c2a2c89 (diff)
downloadmrst-s0i3-test-8ea91226eccf6c8ab9c55054b24c21021d4d9d19.tar.gz
mrst-s0i3-test-8ea91226eccf6c8ab9c55054b24c21021d4d9d19.tar.xz
mrst-s0i3-test-8ea91226eccf6c8ab9c55054b24c21021d4d9d19.zip
net: caif: spi: fix potential NULL dereference
alloc_netdev() is not checked here for NULL return value. dev is check instead. It might lead to NULL dereference of ndev. Signed-off-by: Vasiliy Kulikov <segoon@openwall.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/caif/caif_spi.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/caif/caif_spi.c b/drivers/net/caif/caif_spi.c
index 8b4cea57a6c..20da1996d35 100644
--- a/drivers/net/caif/caif_spi.c
+++ b/drivers/net/caif/caif_spi.c
@@ -635,8 +635,8 @@ int cfspi_spi_probe(struct platform_device *pdev)
ndev = alloc_netdev(sizeof(struct cfspi),
"cfspi%d", cfspi_setup);
- if (!dev)
- return -ENODEV;
+ if (!ndev)
+ return -ENOMEM;
cfspi = netdev_priv(ndev);
netif_stop_queue(ndev);