aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEric Dumazet <eric.dumazet@gmail.com>2010-11-18 09:30:42 -0800
committerDavid S. Miller <davem@davemloft.net>2010-11-18 09:30:42 -0800
commit3006bc38895895f1a0352c2e17e1a503f35f7e2f (patch)
tree24a3a9ecbee9215898b4c6b30357740eeeb632bb
parent28cb6ccd2c7e86b3a4db94c7062cd27937bed424 (diff)
downloadmrst-s0i3-test-3006bc38895895f1a0352c2e17e1a503f35f7e2f.tar.gz
mrst-s0i3-test-3006bc38895895f1a0352c2e17e1a503f35f7e2f.tar.xz
mrst-s0i3-test-3006bc38895895f1a0352c2e17e1a503f35f7e2f.zip
bonding: fix a race in IGMP handling
RCU conversion in IGMP code done in net-next-2.6 raised a race in __bond_resend_igmp_join_requests(). It iterates in_dev->mc_list without appropriate protection (RTNL, or read_lock on in_dev->mc_list_lock). Another cpu might delete an entry while we use it and trigger a fault. Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/bonding/bond_main.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index bdb68a60038..71a169740d0 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -878,8 +878,10 @@ static void __bond_resend_igmp_join_requests(struct net_device *dev)
rcu_read_lock();
in_dev = __in_dev_get_rcu(dev);
if (in_dev) {
+ read_lock(&in_dev->mc_list_lock);
for (im = in_dev->mc_list; im; im = im->next)
ip_mc_rejoin_group(im);
+ read_unlock(&in_dev->mc_list_lock);
}
rcu_read_unlock();