aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEric Dumazet <eric.dumazet@gmail.com>2010-10-15 14:34:12 -0700
committerLinus Torvalds <torvalds@linux-foundation.org>2010-10-15 14:42:24 -0700
commita9febbb4bd1302b6f01aa1203b0a804e4e5c9e25 (patch)
tree7367bee631d0a050e0d392102dd652ec48a57a08
parent5a2b3ef4559f3d0ef58cbfb723f528f1c6b2e601 (diff)
downloadmrst-s0i3-test-a9febbb4bd1302b6f01aa1203b0a804e4e5c9e25.tar.gz
mrst-s0i3-test-a9febbb4bd1302b6f01aa1203b0a804e4e5c9e25.tar.xz
mrst-s0i3-test-a9febbb4bd1302b6f01aa1203b0a804e4e5c9e25.zip
sysctl: min/max bounds are optional
sysctl check complains with a WARN() when proc_doulongvec_minmax() or proc_doulongvec_ms_jiffies_minmax() are used by a vector of longs (with more than one element), with no min or max value specified. This is unexpected, given we had a bug on this min/max handling :) Reported-by: Jiri Slaby <jirislaby@gmail.com> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> Cc: "Eric W. Biederman" <ebiederm@xmission.com> Cc: David Miller <davem@davemloft.net> Acked-by: WANG Cong <xiyou.wangcong@gmail.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--kernel/sysctl_check.c9
1 files changed, 0 insertions, 9 deletions
diff --git a/kernel/sysctl_check.c b/kernel/sysctl_check.c
index 04cdcf72c82..10b90d8a03c 100644
--- a/kernel/sysctl_check.c
+++ b/kernel/sysctl_check.c
@@ -143,15 +143,6 @@ int sysctl_check_table(struct nsproxy *namespaces, struct ctl_table *table)
if (!table->maxlen)
set_fail(&fail, table, "No maxlen");
}
- if ((table->proc_handler == proc_doulongvec_minmax) ||
- (table->proc_handler == proc_doulongvec_ms_jiffies_minmax)) {
- if (table->maxlen > sizeof (unsigned long)) {
- if (!table->extra1)
- set_fail(&fail, table, "No min");
- if (!table->extra2)
- set_fail(&fail, table, "No max");
- }
- }
#ifdef CONFIG_PROC_SYSCTL
if (table->procname && !table->proc_handler)
set_fail(&fail, table, "No proc_handler");