aboutsummaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorJingYi Hou <houjingyi647@gmail.com>2019-06-17 14:56:05 +0800
committerDavid S. Miller <davem@davemloft.net>2019-06-18 10:04:16 -0700
commitd0bae4a0e3d8c5690a885204d7eb2341a5b4884d (patch)
treeab344ba88e15da3f4a985f9ee4e662b0563fbfc3 /net
parentd0f84d0856c11fbafadae3d580f6a9c98d818ccd (diff)
downloadtip-d0bae4a0e3d8c5690a885204d7eb2341a5b4884d.tar.gz
tip-d0bae4a0e3d8c5690a885204d7eb2341a5b4884d.tar.xz
tip-d0bae4a0e3d8c5690a885204d7eb2341a5b4884d.zip
net: remove duplicate fetch in sock_getsockopt
In sock_getsockopt(), 'optlen' is fetched the first time from userspace. 'len < 0' is then checked. Then in condition 'SO_MEMINFO', 'optlen' is fetched the second time from userspace. If change it between two fetches may cause security problems or unexpected behaivor, and there is no reason to fetch it a second time. To fix this, we need to remove the second fetch. Signed-off-by: JingYi Hou <houjingyi647@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
-rw-r--r--net/core/sock.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/net/core/sock.c b/net/core/sock.c
index af09a23e4822..aa4a00d381e3 100644
--- a/net/core/sock.c
+++ b/net/core/sock.c
@@ -1477,9 +1477,6 @@ int sock_getsockopt(struct socket *sock, int level, int optname,
{
u32 meminfo[SK_MEMINFO_VARS];
- if (get_user(len, optlen))
- return -EFAULT;
-
sk_get_meminfo(sk, meminfo);
len = min_t(unsigned int, len, sizeof(meminfo));