aboutsummaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorTrond Myklebust <trondmy@gmail.com>2019-06-20 10:47:40 -0400
committerAnna Schumaker <Anna.Schumaker@Netapp.com>2019-06-21 14:45:09 -0400
commit19d55046cd824baab53534ba7e7f99945c6fdcb1 (patch)
tree2d07b1e71d1f987d7a38496abe2d10e3c19c3ea4 /net
parent502980e84e4025d82e81f7d9684a708a3b31bcde (diff)
downloadtip-19d55046cd824baab53534ba7e7f99945c6fdcb1.tar.gz
tip-19d55046cd824baab53534ba7e7f99945c6fdcb1.tar.xz
tip-19d55046cd824baab53534ba7e7f99945c6fdcb1.zip
SUNRPC: Fix a credential refcount leak
All callers of __rpc_clone_client() pass in a value for args->cred, meaning that the credential gets assigned and referenced in the call to rpc_new_client(). Reported-by: Ido Schimmel <idosch@idosch.org> Fixes: 79caa5fad47c ("SUNRPC: Cache cred of process creating the rpc_client") Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com> Tested-by: Ido Schimmel <idosch@mellanox.com> Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
Diffstat (limited to 'net')
-rw-r--r--net/sunrpc/clnt.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c
index 2b353472364f..b03bfa055c08 100644
--- a/net/sunrpc/clnt.c
+++ b/net/sunrpc/clnt.c
@@ -634,7 +634,6 @@ static struct rpc_clnt *__rpc_clone_client(struct rpc_create_args *args,
new->cl_discrtry = clnt->cl_discrtry;
new->cl_chatty = clnt->cl_chatty;
new->cl_principal = clnt->cl_principal;
- new->cl_cred = get_cred(clnt->cl_cred);
return new;
out_err: