path: root/kernel
diff options
authorChenbo Feng <fengc@google.com>2019-05-14 19:42:57 -0700
committerAlexei Starovoitov <ast@kernel.org>2019-05-16 11:31:49 -0700
commite547ff3f803e779a3898f1f48447b29f43c54085 (patch)
tree57ee781efe7e061b8a8a822c80744f2b4c37a40b /kernel
parent2407a88a13a2d03ea9b8c86bbdedb3eff80c4b9e (diff)
bpf: relax inode permission check for retrieving bpf program
For iptable module to load a bpf program from a pinned location, it only retrieve a loaded program and cannot change the program content so requiring a write permission for it might not be necessary. Also when adding or removing an unrelated iptable rule, it might need to flush and reload the xt_bpf related rules as well and triggers the inode permission check. It might be better to remove the write premission check for the inode so we won't need to grant write access to all the processes that flush and restore iptables rules. Signed-off-by: Chenbo Feng <fengc@google.com> Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Diffstat (limited to 'kernel')
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/bpf/inode.c b/kernel/bpf/inode.c
index bc53e5b20ddc..84a80b02db99 100644
--- a/kernel/bpf/inode.c
+++ b/kernel/bpf/inode.c
@@ -518,7 +518,7 @@ out:
static struct bpf_prog *__get_prog_inode(struct inode *inode, enum bpf_prog_type type)
struct bpf_prog *prog;
- int ret = inode_permission(inode, MAY_READ | MAY_WRITE);
+ int ret = inode_permission(inode, MAY_READ);
if (ret)
return ERR_PTR(ret);