Add FIXME: watch out for excessive fragmentation when shrinking anto-tytso-20011015

allocation with realloc().

1 files changed, 4 insertions, 0 deletions

diff --git a/alloc.c b/alloc.c
index 9b22672..39a2585 100644
--- a/alloc.c
+++ b/alloc.c
@@ -734,6 +734,10 @@ static void *objstore_realloc_buddy(void *ptr, size_t new_size)
     /* Allocation shrink.  Return the extra space to the arena;
        no copy. */
 
+    /*** FIXME: this could be bad for fragmentation if the
+     *** allocation size delta is large.  Consider adding a
+     *** heuristic copy to a less prime spot if delta is large. */
+
     /* Clear the old allocation size bit. */
     xbit = bp.xbit;
     clr_bit(ah->alloc_bitmap, xbit);